Skip to content

Fix finding codeownersDirectory on windows with parent folder #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noahm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix finding codeownersDirectory on windows with parent folder #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions codeowners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ function ownerMatcher(pathString) {
return matcher.ignores.bind(matcher);
}

const PARENT_FOLDERS = ['.github', '.gitlab', 'docs'];

function Codeowners(currentPath, fileName = 'CODEOWNERS') {
const pathOrCwd = currentPath || process.cwd();

const codeownersPath = findUp.sync(
[`.github/${fileName}`, `.gitlab/${fileName}`, `docs/${fileName}`, `${fileName}`],
PARENT_FOLDERS.map((folder) => path.join(folder, fileName)).concat(fileName),
{ cwd: pathOrCwd }
);

Expand All @@ -30,7 +32,7 @@ function Codeowners(currentPath, fileName = 'CODEOWNERS') {

// We might have found a bare codeowners file or one inside the three supported subdirectories.
// In the latter case the project root is up another level.
if (this.codeownersDirectory.match(/\/(.github|.gitlab|docs)$/i)) {
if (PARENT_FOLDERS.includes(path.basename(this.codeownersDirectory))) {
this.codeownersDirectory = path.dirname(this.codeownersDirectory);
}

Expand Down