Neptune R900 full 8 digit consumption#270
Open
rybancr wants to merge 5 commits intobemasher:masterfrom
Open
Conversation
Decreased NoUse and Leak to 3 bits. Leak contained the LSB of the consumption high bits field. Removed Unkn3. Extended consumption to use the two consumption high bits located in Unkn3 and one from leak to allow for full 8 digit reads. 24 bits allow a consumption up to 16,777,215 before prematurely rolling over.
robbat2
reviewed
May 27, 2023
robbat2
left a comment
robbat2
left a comment
There was a problem hiding this comment.
Do we have some documentation that tells us what the AmrType values are?
For my data samples, I'm not sure this is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepended the consumption register high bits to allow full 8 digit reads.
Mapped the meter type field.
Reduced the nouse and leak fields to 3 bits as they were overflowing into adjacent fields.