Unified models for progress tracks and clocks#820
Draft
rsek wants to merge 48 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes of note (WIP)
progressandtruthJEPsProgressLikedata model; abstract class to provide constants and functions common to progress track-like objects (with the exception of classic bonds, which might get rewritten as part of Explore representing classic-style bonds asActiveEffects #818 , anyways)LegacyTrack(extendsProgressLike); each player character legacy track is now a single object whose source data is{ticks: number, xpSpent: number}ProgressTrack(extendsProgressLike), which replaces every progress track that isn't a legacy track or bond trackticksbondrenamed toconnection; uses SF's "Forge a Bond" move when rolling progressdelve, which is only used internally; it identifies delve progress tracks to progress-related methods; uses delve's "Locate Your Objective" move when rolling progresssystem.trackprogressJEP, which are intentionally more "atomic".Clockdata modelChallengeRankFieldrenamed toChallengeRank; supplies most challenge rank constants and utility functions as statics