You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
services/action/dist/index.js — rebuilt bundle (single-line JSON change reflecting new API spec version)
Review notes:
Inconsistency in tsconfig lineage: The previous config extended @tsconfig/node18 but the CI was running Node 20. Now it's consistent at Node 22 — good improvement.
dist/index.js rebuild: The diff in the bundled file is a single line change to an embedded JSON string (OpenAPI spec version bump 0.5.10 → 0.5.11). This appears to be from a rebuild that picked up a spec change, not from the Node upgrade itself. This is fine but worth noting — the bundle was regenerated.
Node 22 is LTS: Node 22 entered LTS in October 2024 and is actively maintained. GitHub Actions supports node22 as a runtime. This is a safe upgrade.
No issues found. The changes are mechanical and consistent across all locations.
Commit 2: Add rate limiting for OCI bandwidth usage (#700)
This commit is not included in the diff (git diff devel...HEAD doesn't show it beyond the stat line). Looking at the commit log, it appears commit 178c98ddf is between c5655e414 (node22) and HEAD, but the diff shows only the node22 changes. This likely means the rate limiting commit was already merged into devel or its changes are already present on both sides.
Verdict: Only the Node 22 upgrade changes are net-new in this PR.
Summary
Area
Assessment
Code quality
Clean, consistent mechanical change
Bugs
None identified
Security
No concerns — Node 22 LTS is well-supported
Performance
Node 22 includes V8 performance improvements; net positive
CLAUDE.md compliance
N/A (no Rust changes)
Overall: Looks good. Straightforward Node.js version bump with consistent updates across all touchpoints.
Current runner version: '2.332.0'
Runner Image Provisioner
Operating System
Runner Image
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'bencherdev/bencher@devel' (SHA:5310b7ef32c95c5aba006104212d94b33c5afcb3)
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node22' is not supported, use 'docker', 'node12', 'node16', 'node20' or 'node24' instead.')
at GitHub.Runner.Worker.ActionManifestManagerLegacy.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManagerLegacy.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load bencherdev/bencher/devel/action.yml
epompeii
changed the title
Upgrade GitHub Action from Node 20 to Node 22
Upgrade GitHub Action from Node 20 to Node ~~22~~ 24
Mar 13, 2026
epompeii
changed the title
Upgrade GitHub Action from Node 20 to Node ~~22~~ 24
Upgrade GitHub Action from Node 20 to Node 22
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 has been deprecated by GitHub. This changeset upgrades to Node 22, as requested in #698.