Resolution of positioning problem#185
Open
k-soze wants to merge 1 commit into
Open
Conversation
The positioning did not work when positionPopup(step) was called after setting the visibility and display style because the width and height (used in tether) of the popup were equal to 0.
Owner
|
Hey @k-soze I'm sorry I never saw this come in. Thank you for the PR, I'll take a look. In the meantime I am releasing an update that should fix most of the positioning issues. |
|
+1 for this PR. @benmarch this seems to have fixed some placement issues I was experiencing. Some of the pop ups were appearing shifted a few inches to the right when the options 'bottom' or 'left' where being used. Until this is merged in, I'll use a forked version that includes this fix. Thanks @k-soze! |
sylvainbx
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The positioning did not work when positionPopup(step) was called after setting the visibility and display style because the width and height (used in tether) of the popup were equal to 0.