feat: add generic parser filters to parse and search - #152
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds generic bgpkit-parser filters to local and remote parse/search workflows.
Changes:
- Adds repeatable generic filter expressions with validation.
- Forwards extended filters through SSE remote search.
- Normalizes remote duration-based searches to epoch bounds.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/lens/parse/mod.rs |
Parses and applies generic filters. |
src/lens/search/mod.rs |
Validates parser filters before search. |
src/server/search.rs |
Accepts generic filters over SSE. |
src/bin/commands/search.rs |
Forwards filters and normalizes time bounds. |
src/bin/commands/search_remote.rs |
Extends the remote wire DTO. |
CHANGELOG.md |
Documents the feature. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--filter key=value|key!=valueexpressions to parse and searchstart + durationsearches to explicit UTC epoch boundsValidation
cargo fmt -- --checkcargo clippy --all-features -- -D warningscargo test --all-featuresip_versionand rejected generic time filters