Skip to content

Dev#73

Merged
ypriverol merged 2 commits intomainfrom
dev
Mar 30, 2026
Merged

Dev#73
ypriverol merged 2 commits intomainfrom
dev

Conversation

@ypriverol
Copy link
Copy Markdown
Member

@ypriverol ypriverol commented Mar 30, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved processing of .d.zip formatted file paths in experimental design parsing to ensure accurate matching between DIA-NN report file identifiers and design specifications.

@ypriverol ypriverol merged commit 9e90db6 into main Mar 30, 2026
5 of 7 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d8489e80-c521-4ffe-8fa9-9e1ae03f589e

📥 Commits

Reviewing files that changed from the base of the PR and between 7246fea and e61c891.

📒 Files selected for processing (1)
  • quantmsutils/diann/diann2msstats.py

📝 Walkthrough

Walkthrough

Updated the _true_stem function in the DIA-NN to MS Stats conversion module to apply double stemming for paths ending with .d.zip (removing both .zip and .d suffixes), while preserving single stemming for other inputs. This changes matching behavior for DIA-NN report "Run" stems against design file stems.

Changes

Cohort / File(s) Summary
DIA-NN Stem Processing
quantmsutils/diann/diann2msstats.py
Updated _true_stem function to handle .d.zip file extensions by applying Path(...).stem twice, affecting how run values are derived in unified and legacy experimental design parsing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A stem that now knows a trick so fine,
When .d.zip arrives, it peels with design,
Double the work, but matching's more right,
DIA-NN runs shine in the spotlight! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants