Skip to content

Minor changes and refinements #75

Merged
ypriverol merged 10 commits intomainfrom
dev
Mar 30, 2026
Merged

Minor changes and refinements #75
ypriverol merged 10 commits intomainfrom
dev

Conversation

@ypriverol
Copy link
Copy Markdown
Member

@ypriverol ypriverol commented Mar 30, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Version updated to 0.0.27
    • Updated build system configuration and related development requirements
    • Refined runtime dependency version constraints for consistency
    • Reorganized package metadata structure and configuration layout
    • Enhanced declaration of package entry points

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@ypriverol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68068568-054e-4870-b90e-08676f4b0dae

📥 Commits

Reviewing files that changed from the base of the PR and between 9e90db6 and 0bd595a.

⛔ Files ignored due to path filters (3)
  • .DS_Store is excluded by !**/.DS_Store
  • quantmsutils/.DS_Store is excluded by !**/.DS_Store
  • tests/.DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing (5)
  • .github/workflows/conda-build.yml
  • .gitignore
  • pyproject.toml
  • recipe/conda_build_config.yaml
  • recipe/meta.yaml
📝 Walkthrough

Walkthrough

Migrates project packaging from Poetry to PEP 621-compliant metadata with Hatch build system. Replaces static version declaration with dynamic VCS-based versioning. Updates Conda recipe with new build tool dependencies, package version, and sdrf-pipelines constraint.

Changes

Cohort / File(s) Summary
Build system migration
pyproject.toml
Transitions packaging configuration from [tool.poetry] to [project] format. Converts version from static field to dynamic VCS-sourced value via Hatch. Relocates dependencies, URLs, and script entry points to PEP 621 sections. Replaces poetry-core with hatchling build backend.
Conda recipe updates
recipe/meta.yaml
Bumps package version from 0.0.26 to 0.0.27. Replaces build host requirements from poetry-core >=1.2.0 to hatchling and hatch-vcs. Updates runtime dependency for sdrf-pipelines from >=0.1.1 to >=0.1.2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #56: Modifies sdrf-pipelines runtime dependency version constraint in the same Conda recipe file
  • PR #32: Updates sdrf-pipelines dependency version in recipe/meta.yaml with similar structural changes
  • PR #71: Includes both package version bump and sdrf-pipelines dependency constraint increase in the same files

Poem

🐰 From Poetry's verse to Hatch's dynamic rhyme,
Our build system evolves with the march of time,
Static versions yield to VCS's call,
PEP 621 standards guide us all! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Dev' is vague and generic, failing to convey meaningful information about the substantial changes made to the project's build system and dependencies. Use a descriptive title that reflects the main change, such as 'Migrate from Poetry to Hatch build system' or 'Switch packaging configuration from Poetry to PEP 621 with Hatch'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 3 commits March 30, 2026 15:00
…tignore

Remove conda recipe and .DS_Store files; update .gitignore
@ypriverol ypriverol changed the title Dev Minor changes and refinements Mar 30, 2026
@ypriverol
Copy link
Copy Markdown
Member Author

@copilot can you fix this this: python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
pip install poetry
poetry build
pip install dist/*.whl
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.10.20/x64

Is produceing error

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot can you fix this this: python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
...

Fixed in commit 29bce25. The project migrated from Poetry to Hatchling, but the CI workflow still called poetry build, which failed because [tool.poetry.version] is no longer present. Replaced pip install poetry + poetry build with pip install build + python -m build, which uses the Hatchling build backend defined in pyproject.toml.

@ypriverol
Copy link
Copy Markdown
Member Author

@copilot still we have an issue python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
pip install poetry
poetry build
pip install dist/*.whl
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.10.20/x64

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot still we have an issue python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
...

The python-app.yml workflow also still had pip install poetry + poetry build + poetry run pytest. Fixed in commit df7a417 — same approach: replaced with pip install build + python -m build + plain pytest.

@ypriverol ypriverol merged commit 39d82a1 into main Mar 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants