Skip to content

fix tests to also work with filelock > 3.29.4 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hejung merged 1 commit into from
Jul 6, 2026
Merged

fix tests to also work with filelock > 3.29.4 #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/trajectory/test_propagate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ async def test_run_continue_remove_with_gromacs(
# mda version 2.2.0 and fasteners does not remove lock files)
# - filelock removes lockfiles on win with filelock version >= 3.25.1
# - filelock removes lockfiles on unix with filelock version >= 3.20.4
# and then stopped removing them again with version 3.29.5,
# see: https://github.com/tox-dev/filelock/pull/577
try:
import filelock
except ImportError:
Expand All @@ -237,9 +239,14 @@ async def test_run_continue_remove_with_gromacs(
else:
# lockfile used instead of fasteners
if os.name == "posix":
files_per_traj = (
2 if Version(filelock.__version__) >= Version("3.20.4")
else 3)
files_per_traj = 3
if (
Version("3.29.5")
> Version(filelock.__version__)
>= Version("3.20.4")
):
# we are in the version range that removes the lockfiles
files_per_traj -= 1
elif os.name == "nt":
files_per_traj = (
2 if Version(filelock.__version__) >= Version("3.25.1")
Expand Down
Loading