Remove deprecated NumPy string dtype alias#165
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Mirochill <200482516+Mirochill@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What new features does this PR implement?
None.
What bugs does this PR fix?
numpy.dtype(a)from report dtype validation (closes DeprecationWarning: Data type alias 'a' was deprecated in NumPy 2.0. Use the 'S' alias instead. #163).Does this PR introduce any additional changes?
None.
How have you tested this PR?
Not run locally.
Static validation:
git diff --check HEAD~1..HEADgit show --stat --oneline --summary HEADnumpy.dtype(a)is no longer used inbiosimulators_utils/report/io.pyandnumpy.dtype(S)remains in the validation list.Remote CI:
Continuous integrationrun 26416898040 isaction_requiredwith no jobs or logs available yet.Additional information
The change is limited to replacing the deprecated alias usage with the existing
Sbytestring dtype entry that was already checked on the same line.