Skip to content

Fix option min validation and formatter include#452

Merged
DylanWelzel merged 1 commit into
biothings:1.1.xfrom
sdraeger:fix-web-option-formatter-bugs
Jul 23, 2026
Merged

Fix option min validation and formatter include#452
DylanWelzel merged 1 commit into
biothings:1.1.xfrom
sdraeger:fix-web-option-formatter-bugs

Conversation

@sdraeger

Copy link
Copy Markdown
Contributor

Summary

  • Fix list minimum-length validation so lists shorter than the configured minimum are rejected.
  • Fix FormatterDict.include() so it keeps requested keys instead of removing them.
  • Add regression tests for both behaviors.

Testing

  • python -m pytest tests/web/options/test_options.py tests/web/query/test_formatter.py

@DylanWelzel
DylanWelzel changed the base branch from master to 1.1.x July 23, 2026 19:49
@DylanWelzel

Copy link
Copy Markdown
Contributor

Thanks for the fix. I verified the patch and tests, and retargeted this PR to 1.1.x since that’s the intended release branch.

@DylanWelzel
DylanWelzel merged commit e39d3b6 into biothings:1.1.x Jul 23, 2026
1 check passed
@DylanWelzel DylanWelzel mentioned this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants