Skip to content

Fixed PointOfInterest template and added openUrl#153

Open
blanck wants to merge 24 commits into
birkir:masterfrom
blanck:master
Open

Fixed PointOfInterest template and added openUrl#153
blanck wants to merge 24 commits into
birkir:masterfrom
blanck:master

Conversation

@blanck

@blanck blanck commented Nov 8, 2023

Copy link
Copy Markdown

PointOfInterest template has been updated with:
Parameters

  • primaryButton
  • secondaryButton
  • pinImage
  • selectedPinImage
    Actions
  • setPointsOfInterest
  • setPointOfInterestTitle
    Events
  • didChangeMapRegion

OpenURL method added
Store and connect controller updated to include scene. Required to enable openUrl function to open other apps from an action button. Example to open a navigation app (Maps, Google Maps, Waze) and navigate to a POI.
Example code:
const url = 'maps://?q=London&ll=51.5074256%2C-0.1271814'; CarPlay.openUrl(url);

@birkir

birkir commented Nov 13, 2023

Copy link
Copy Markdown
Owner

Very nice! Thank you for the contribution.

@birkir

birkir commented Nov 18, 2023

Copy link
Copy Markdown
Owner

We are getting lockfile conflict because of "react-native": "" and "react": ""

Any reason for the change?

image

Once tests pass I'll merge!

@ElangoPrince

ElangoPrince commented Nov 24, 2023

Copy link
Copy Markdown

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

@birkir

birkir commented Nov 24, 2023

Copy link
Copy Markdown
Owner

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

It's not ready as far as I'm concerned.

@ElangoPrince

Copy link
Copy Markdown

@birkir Ohh, Okay. I'm waiting for this update. Its blocking me to proceed further. Can you give any possible way to use POI for now?

@birkir

birkir commented Nov 24, 2023

Copy link
Copy Markdown
Owner

You can easily apply patches to any packages if you want.
If using yarn 2+ you can use yarn patch
Otherwise you can use patch-package

Feel free to use changes from this PR

@saikiranm33

Copy link
Copy Markdown

@blanck still seeing the unsupported object issue

@"albumArtistButtonPressed",
// poi
@"didSelectPointOfInterest",
@"didChangeMapRegion",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #204 as well

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we apply this only in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants