Skip to content

Implement Addresses list in Settings screen#561

Open
pseudoramdom wants to merge 17 commits intobitcoin-core:qt6from
pseudoramdom:address-book
Open

Implement Addresses list in Settings screen#561
pseudoramdom wants to merge 17 commits intobitcoin-core:qt6from
pseudoramdom:address-book

Conversation

@pseudoramdom
Copy link
Copy Markdown
Contributor

Add support to view receive and change addresses. (Implements #519)

  • Add addresslistmodel
    • exposes wallet-owned receive and change addresses to QML including labels, usage state, balances, formatter amounts, script type etc.
    • This will be owned by WalletQmlModel which provides helper methods related to addresses.
  • Add a reusable control SegmentedPicker.qml for segmented picker with multiple options.

Tests

  • Updated functional wallet harness so app-only GUI tests do not require a built bitcoind.

Review notes

Screenshots

Screenshot 2026-04-29 at 10 29 18 AM Screenshot 2026-04-29 at 10 29 25 AM Screenshot 2026-04-29 at 10 29 29 AM Screenshot 2026-04-29 at 10 29 36 AM Screenshot 2026-04-29 at 10 29 38 AM

Copy link
Copy Markdown
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to reuse the toggle buttons in the NetworkTraffic page?

@pseudoramdom
Copy link
Copy Markdown
Contributor Author

Can we try to reuse the toggle buttons in the NetworkTraffic page?

Good callout.
I’ll update SegmentedPicker to use ToggleButton internally, so it gets the same visual interaction style as NetworkTraffic. I'd still keep the SegmentedPicker since it's a higher-level grouped control: it takes a model, owns currentIndex, emits selected(index, option), and avoids repeating the RowLayout + Repeater + checked/index wiring anywhere we need a segmented choice.

@pseudoramdom
Copy link
Copy Markdown
Contributor Author

Rebased on top of #546 (e5fab68)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants