Guidepoint: Enhancement - Prevent request caching axios#2033
Merged
JohnathanWhite merged 1 commit intobitpay:masterfrom Mar 3, 2026
Merged
Guidepoint: Enhancement - Prevent request caching axios#2033JohnathanWhite merged 1 commit intobitpay:masterfrom
JohnathanWhite merged 1 commit intobitpay:masterfrom
Conversation
1543a2f to
8c4d49e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cache-busting headers to network requests to reduce the chance of clients/proxies returning stale responses.
Changes:
- Adds
Cache-Control/Pragma/Expiresheaders to manyaxiosrequests across the app. - Adds the same no-cache headers to internal
fetchhelpers (src/utils/passkey.ts). - Updates various effects/APIs to pass those headers along with existing request headers/config.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/passkey.ts | Adds no-cache headers to shared fetch GET/POST helper functions. |
| src/utils/helper-methods.ts | Adds no-cache headers to Solana-related axios calls (one call has a config-shape issue). |
| src/store/wallet/effects/send/send.ts | Adds no-cache headers to UTXO tx fetch. |
| src/store/wallet/effects/rates/rates.ts | Adds no-cache headers to fiat rate fetching (config-shape issues present). |
| src/store/wallet/effects/currencies/currencies.ts | Adds no-cache headers to token options fetch. |
| src/store/swap-crypto/effects/thorswap/thorswap.ts | Adds no-cache headers to Thorswap calls. |
| src/store/swap-crypto/effects/changelly/changelly.ts | Adds no-cache headers to Changelly calls. |
| src/store/shop/shop.effects.ts | Adds no-cache headers to shop endpoints (one POST has a config-shape issue). |
| src/store/scan/scan.effects.ts | Adds no-cache headers to invoice-related calls. |
| src/store/market-stats/market-stats.effects.ts | Adds no-cache headers to market stats call. |
| src/store/external-services/external-services.effects.ts | Adds no-cache headers to external services config calls. |
| src/store/card/card.effects.ts | Adds no-cache headers to invoice fetch after top-up creation. |
| src/store/buy-crypto/effects/transak/transak.ts | Adds no-cache headers to Transak calls. |
| src/store/buy-crypto/effects/simplex/simplex.ts | Adds no-cache headers to Simplex calls. |
| src/store/buy-crypto/effects/sardine/sardine.ts | Adds no-cache headers to Sardine calls. |
| src/store/buy-crypto/effects/ramp/ramp.ts | Adds no-cache headers to Ramp calls. |
| src/store/buy-crypto/effects/moonpay/moonpay.ts | Adds no-cache headers to Moonpay calls. |
| src/store/buy-crypto/effects/banxa/banxa.ts | Adds no-cache headers to Banxa calls. |
| src/store/bitpay-id/bitpay-id.effects.ts | Adds no-cache headers to BitPay ID wallet lookup (config-shape issue present). |
| src/store/app/app.effects.ts | Adds no-cache headers to waitlist join call; minor formatting tweak in pinning config. |
| src/lib/Braze/index.ts | Adds no-cache headers to Braze merge/delete calls. |
| src/components/modal/import-ledger-wallet/import-account/SelectLedgerCurrency.tsx | Adds no-cache headers to address tx fetch. |
| src/api/zenledger/index.ts | Adds no-cache headers to Zenledger auth/data calls. |
| src/api/graphql/index.ts | Adds no-cache headers to GraphQL API calls. |
| src/api/etherscan/index.ts | Adds no-cache headers to Etherscan calls. |
| src/api/coinbase/index.ts | Adds no-cache headers to Coinbase calls. |
| src/api/bitpay/index.ts | Adds no-cache headers to BitPay ID API calls. |
| src/api/auth/index.ts | Adds no-cache headers to session/auth endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
418194d to
0a72cc5
Compare
| } from './zenledger.types'; | ||
|
|
||
| import {ZENLEDGER_CREDENTIALS, ZENLEDGER_API_URL} from './zenledger.constants'; | ||
| import {NO_CACHE_HEADERS} from '@/constants/config'; |
Collaborator
There was a problem hiding this comment.
this is returning an "unable to resolve module" error.
Collaborator
|
Are Moralis requests missing the |
df4ae52 to
c9a8602
Compare
c9a8602 to
53f7b80
Compare
JohnathanWhite
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GP-22 (Part 2/2)