Open
Conversation
Although errors and warnings are being logged, some times the strategies result in empty sets of nodes. Being able to see more information in the logs is helpful to troubleshoot complex cluster systems.
|
Please fix conflcts @abravalheri |
Author
|
Hi @beardedeagle, thank you for the message. Before rushing to fix the conflicts, did you had the chance to have a quick look at the proposed changes? Do they make sense? I wonder if that is the best way to go, or something different would be the best (e.g. using the default Elixir logger, or relying on macros to eliminate overhead). (Sorry this was submitted 1 year ago, and since I had no interactions from the maintainers I thought maybe the design of this change was inconsistent with their long-term vision) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although errors and warnings are being logged, some times the strategies
result in empty sets of nodes. Being able to see more information in the
logs is helpful to troubleshoot complex cluster systems.