Update CI, dependencies and fix deprecations#772
Update CI, dependencies and fix deprecations#772nathany-copia wants to merge 1 commit intobitwalker:mainfrom
Conversation
| end | ||
|
|
||
| Module.eval_quoted(__MODULE__, day_quoted, [], __ENV__) | ||
| Code.eval_quoted(day_quoted, [], __ENV__) |
There was a problem hiding this comment.
Code.eval_quoted exists in very early versions of Elixir, so this shouldn't impact the minimum Elixir version required for this library.
Test with current versions of dependencies Module.eval_quoted/4 is deprecated. Use Code.eval_quoted/3 instead
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: ${{ matrix.experimental }} |
There was a problem hiding this comment.
The idea with this experimental flag is it allows testing with release candidates of future elixir versions without breaking the build or preventing a merge, but it allows the results of to be seen in CI.
|
Would be nice if this could get merged and released! |
|
@bitwalker Any chance you could review this? Is there anyone else able to approve the workflow and merge PRs? |
|
Does anyone have suggestions on how to handle #773? I'd like all the tests to pass in CI with the latest version of Elixir + Erlang. |
|
Any chance this could be merged? |
|
I've already published a new release with updated deps, could you update this PR to resolve the conflicts, and I can merge and publish a new release? |
|
@nathany-copia Do you have time to update this PR? |
|
In case Nathan doesn't have time now, I have opened #781 without the CI changes so this PR could still be merged in the future |
7 participants
Summary of changes
Updates Timex CI and dependencies to resolve compiler warnings and ensure that the code compiles and tests pass in the most recent 2 versions of Elixir (if additional older versions are desired, those can be added)
Fixes #771
Checklist
https://github.com/elixir-gettext/gettext/blob/main/CHANGELOG.md#v0260