Relax gettext dependency constraint to allow >= 0.26.0#783
Relax gettext dependency constraint to allow >= 0.26.0#783patrols wants to merge 1 commit intobitwalker:mainfrom
Conversation
|
Yes, would nice, we also can't update our lib without this |
mix.exs
Outdated
| {:tzdata, "~> 1.1"}, | ||
| {:combine, "~> 0.10"}, | ||
| {:gettext, "~> 0.26"}, | ||
| {:gettext, "~> 1.0"}, |
There was a problem hiding this comment.
This forces applications to use Gettext v1.0 or higher. As there are no breaking changes and "very few changes from the latest 0.26 release", we might want to set the constraint to something like this:
| {:gettext, "~> 1.0"}, | |
| {:gettext, ">= 0.26.0"}, |
There was a problem hiding this comment.
Yeah, good suggestion. Thanks 👍
This allows users to choose between gettext 0.26.x and 1.0.x versions, maintaining backward compatibility while enabling forward compatibility.
patrols
force-pushed
the
update-gettext-1.0
branch
from
b07e063 to
aa4d7a9
Compare
patrols
changed the title
|
+1. Can we merge it? |
|
Would be really nice! |
|
need it too |
|
@ddon @mberrueta-cn I'm curious why you need this PR so badly. Is there anything preventing you from doing |
|
@bitwalker have you already seen this? |
|
@optikfluffel the answer is in your question: it's a workaround. Not everybody wants to have workarounds in their code. Not every dev might be sure that the The question should be "Is there anything preventing this from being merged and released?", not the other way round. |
Gettext 1.0 introduced a major architectural change that removes compile-time dependencies from modules that use Gettext macros. Previously, changing a .po file would trigger recompilation of every controller, view, and module using translation functions. Now only the Gettext backend itself needs to recompile. Using override: true because Timex 3.7.13 still requires ~> 0.26, but Gettext 1.0 is fully backwards compatible. There's an open PR to fix this upstream: bitwalker/timex#783
8 participants
Summary of changes
Relax gettext dependency constraint to allow >= 0.26.0
This allows users to choose between gettext 0.26.x and 1.0.x versions
gettext 1.0.0 changelog
Checklist
Fixes #782