Virsh name fixes - #24
Open
sarnold wants to merge 3 commits into
Open
Conversation
sarnold
commented
Apr 16, 2026
sarnold
commented
Contributor
- add note about using "unknown" for missing OS variant
- replace virt-install wait arg with wait-for-IP function
sarnold
force-pushed
the
virsh-name-fixes
branch
2 times, most recently
from
April 26, 2026 18:05
1db31e5 to
3a4c1f2
Compare
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
* note this *does not* work with the network config in cloud-config.yml * the proper way to pass net config via cloud-init is by using the right network-config option for virt-install --cloud-init * note the default is still no-network-config (DHCP) if the file is not provided Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
sarnold
force-pushed
the
virsh-name-fixes
branch
2 times, most recently
from
July 23, 2026 19:09
cf3ba36 to
994d337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.