Skip to content

Conversation

@TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Dec 8, 2025

This PR corrects a few errors with the scope rework, namely:

  1. Originally, whitelist was set to None until the preset was baked to signify being untouched by the user (and therefore safe to copy from the target). This pattern had been applied to target, but should instead be applied to seeds, since in this new scope system, seeds inherit that same behavior from whitelist (being copied from target at the end, but only if they are unset by the user).
  2. Removes target_list
  3. Sets some tests back to their original state

@TheTechromancer TheTechromancer self-assigned this Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

📊 Performance Benchmark Report

Comparing scope-rework (baseline) vs scope-rework-patch (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.17ms 4.19ms +0.4%
Bloom Filter Large Scale Dns Brute Force 17.68ms 17.68ms -0.0%
Large Closest Match Lookup 361.66ms 364.23ms +0.7%
Realistic Closest Match Workload 190.99ms 192.50ms +0.8%
Event Validation Full Scan Startup Small Batch 472.30ms 481.18ms +1.9%
Event Validation Full Scan Startup Large Batch 885.45ms 888.20ms +0.3%
Make Event Autodetection Small 31.51ms 30.83ms -2.1%
Make Event Autodetection Large 317.80ms 317.31ms -0.2%
Make Event Explicit Types 13.72ms 13.95ms +1.7%
Excavate Single Thread Small 4.000s 3.990s -0.3%
Excavate Single Thread Large 9.386s 9.343s -0.5%
Excavate Parallel Tasks Small 4.122s 4.117s -0.1%
Excavate Parallel Tasks Large 7.028s 7.010s -0.3%
Is Ip Performance 3.19ms 3.21ms +0.7%
Make Ip Type Performance 11.40ms 11.46ms +0.5%
Mixed Ip Operations 4.49ms 4.53ms +0.8%
Typical Queue Shuffle 62.01µs 62.04µs +0.1%
Priority Queue Shuffle 693.26µs 719.25µs +3.7%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (1f0399c) to head (31b1dad).
⚠️ Report is 19 commits behind head on scope-rework.

Additional details and impacted files
@@             Coverage Diff              @@
##           scope-rework   #2817   +/-   ##
============================================
- Coverage            92%     92%   -0%     
============================================
  Files               427     428    +1     
  Lines             34791   34775   -16     
============================================
- Hits              31767   31739   -28     
- Misses             3024    3036   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 0c8a0a4 into scope-rework Dec 9, 2025
12 of 15 checks passed
@liquidsec liquidsec deleted the scope-rework-patch branch December 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants