-
-
Notifications
You must be signed in to change notification settings - Fork 762
Scope rework patch #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope rework patch #2817
Conversation
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.14 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scope-rework #2817 +/- ##
============================================
- Coverage 92% 92% -0%
============================================
Files 427 428 +1
Lines 34791 34775 -16
============================================
- Hits 31767 31739 -28
- Misses 3024 3036 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR corrects a few errors with the scope rework, namely:
whitelistwas set toNoneuntil the preset was baked to signify being untouched by the user (and therefore safe to copy from the target). This pattern had been applied totarget, but should instead be applied toseeds, since in this new scope system, seeds inherit that same behavior from whitelist (being copied fromtargetat the end, but only if they are unset by the user).target_list