fix(buzz-relay): retry S3 conformance probe on startup transport errors - #6288
Open
FvanW wants to merge 1 commit into
Open
fix(buzz-relay): retry S3 conformance probe on startup transport errors#6288FvanW wants to merge 1 commit into
FvanW wants to merge 1 commit into
Conversation
…errors The relay's A3 git-conformance probe ran once at startup and treated any error as fatal, including plain transport failures (connection refused, DNS not resolved) from an S3/MinIO backend that just hadn't finished starting yet. In a compose/systemd deployment with no explicit ordering between the relay and its object store, this crash-looped the relay for a few seconds until the backend came up on its own. Retry only StoreError::Backend (transport-layer) with exponential backoff, bounded by BUZZ_GIT_PROBE_STARTUP_RETRIES (default 5) starting at BUZZ_GIT_PROBE_STARTUP_BACKOFF_MS (default 500ms, capped at 8s). A real ProbeFailure — the backend responded but violated A3 — still fails immediately, since retrying a semantic failure can't fix it. Signed-off-by: Frederick <fred.vanwagenen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acpclients saw connection-refused.StoreError::Backend) with exponential backoff — bounded byBUZZ_GIT_PROBE_STARTUP_RETRIES(default 5), starting atBUZZ_GIT_PROBE_STARTUP_BACKOFF_MS(default 500ms, capped at 8s). A realProbeFailure(backend responded but violated A3) still fails immediately — retrying a semantic conformance failure can't fix it.deploy/charts/buzz/README.mdnext to the existing conformance-probe/readiness notes.Test plan
cargo build -p buzz-relaycargo fmt -p buzz-relay -- --checkcargo clippy -p buzz-relay --no-depscargo test -p buzz-relay --bin buzz-relay(11 passed)🤖 Generated with Claude Code