fix: adding module to export#25
Merged
orest-tokovenko-block merged 2 commits intoJun 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
reportPrivateImportUsagewarnings for downstream consumers importing the auto-generated models fromvantage_sdk.models.Problem
vantage_sdk/models/__init__.pydoesfrom .gen_models import *and then declares its own explicit__all__listing only the hand-written.commonmodels. Per the Python typing spec, an explicit__all__overrides wildcard re-export and becomes the authoritative public interface. The generated models (Folder,CreateFolder,CreateCostExportSchema,UpdateVirtualTagConfig, etc.) are therefore treated as private re-exports, so consumers get warnings like:This only affects third-party
py.typedconsumers, so it does not surface in this repo's own CI.Fix
gen_modelsmodule by name so its export list is referenceablegen_models.__all__to the package__all__so the generated models are part of the public interfaceNo runtime or logic change: the wildcard already binds the names, the
.commonoverrides still win, and overlapping names are harmless duplicates in__all__. The__all__ += module.__all__form is used because it is statically recognized by pyright and does not triggerreportUnsupportedDunderAll(folded] + ...) or ruffRUF005(unpacking).Validation
Reproduced in a clean environment with a non-editable
py.typedwheel:reportPrivateImportUsagewarningsRepo
ruff,ruff format, andbasedpyrightchecks remain green.