Add floating Save Changes button to Blockonomics settings page#421
Open
TandonSuyash wants to merge 1 commit into
Open
Add floating Save Changes button to Blockonomics settings page#421TandonSuyash wants to merge 1 commit into
TandonSuyash wants to merge 1 commit into
Conversation
Collaborator
|
Before another round of changes, I'd like you to step back and rethink the approach from scratch. Smallest change that solves the issue is our goal for the PR. Aim of this task is for you to learn plugin structure, and not to just ship faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Save Changes button on the Blockonomics settings page was only
visible at the bottom, requiring the user to scroll down to save.
This PR adds a floating Save Changes button that:
keeping it as a silent fallback