Issue #748: adding a fallback for file sinks#945
Open
grantlouisherman wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
- Coverage 92.45% 92.37% -0.09%
==========================================
Files 99 99
Lines 11787 11865 +78
Branches 430 430
==========================================
+ Hits 10898 10960 +62
- Misses 889 905 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
31bf555 to
006df64
Compare
006df64 to
7fcea96
Compare
Signed-off-by: grantlouisherman <grantlouisherman041@gmail.com>
c00e01b to
542adb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #748
Describe your changes
I have added a backup for creating files when mmap or other linux based kernel functions are not available
Testing performed
Added two unit tests to test to make sure that if the env variable is set then we fallback to using just
::write