Skip to content

Issue #748: adding a fallback for file sinks#945

Open
grantlouisherman wants to merge 1 commit into
bloomberg:mainfrom
grantlouisherman:file-sink-backup
Open

Issue #748: adding a fallback for file sinks#945
grantlouisherman wants to merge 1 commit into
bloomberg:mainfrom
grantlouisherman:file-sink-backup

Conversation

@grantlouisherman

Copy link
Copy Markdown
Contributor

Issue number of the reported bug or feature request: #748

Describe your changes
I have added a backup for creating files when mmap or other linux based kernel functions are not available

Testing performed
Added two unit tests to test to make sure that if the env variable is set then we fallback to using just ::write

@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.41176% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.37%. Comparing base (5b58e31) to head (542adb0).

Files with missing lines Patch % Lines
src/memray/_memray/sink.cpp 73.52% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   92.45%   92.37%   -0.09%     
==========================================
  Files          99       99              
  Lines       11787    11865      +78     
  Branches      430      430              
==========================================
+ Hits        10898    10960      +62     
- Misses        889      905      +16     
Flag Coverage Δ
cpp 92.37% <89.41%> (-0.09%) ⬇️
python_and_cython 92.37% <89.41%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grantlouisherman grantlouisherman force-pushed the file-sink-backup branch 4 times, most recently from 31bf555 to 006df64 Compare June 11, 2026 20:54
Signed-off-by: grantlouisherman <grantlouisherman041@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants