Add disable comment#177
Closed
nkxxll wants to merge 2 commits intoblopker:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to disable spell checking for files by including a special "spellchecker: disable" comment. The implementation adds a new has_ignore_comment function that checks for language-specific comment syntax and integrates it into the spell checking flow to skip processing when the comment is found.
Key changes:
- Added
has_ignore_commenthelper function with language-specific comment patterns - Integrated ignore comment check into the
spell_checkmethod to return early when detected - Added import for
LanguageTypein the use statement
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
close this in favour of #178 ?! |
Owner
|
Yes, if the new quick action is good enough, I'd prefer that for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know what you think I know this is kind of rudimentary. But with the requirements of fast and easy to work with...well this would work for me 😅.
Again I'm always open for feedback on my code!
ps: When I find the time I'll look into the code actions solution. I see the benefit, I wouldn't want to push "// spellchecker: disable" in production code.