Add Process object so as to allow process.env#4597
Conversation
Test262 conformance changes
Fixed tests (1): |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4597 +/- ##
==========================================
+ Coverage 47.24% 56.49% +9.25%
==========================================
Files 476 547 +71
Lines 46892 60060 +13168
==========================================
+ Hits 22154 33933 +11779
- Misses 24738 26127 +1389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hansl
left a comment
There was a problem hiding this comment.
2 non-blocking nits for now. If you want to merge without addressing that's fine we can do it in a follow up PR.
|
That makes sense. Regarding the new Regarding it being enabled by default, I think we should let it be enabled for now and if in case we strictly don't want it enabled as it's a node api, we'll do a follow up to make it not being enabled by default. |
|
I'd second having the Process extension not on by default. I think this is a super cool extension to have as an option, but since process is not based on a web standard, we should have it be an opt in extension and not opt out. |
|
Done! I've made it optional. |
99bb4b8 to
dd0471a
Compare
nekevss
left a comment
There was a problem hiding this comment.
Thanks! 😄
The feature flag approach looks good to me!
dd0471a to
b4a7f78
Compare
jedel1043
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I have a couple of questions about the implementation
5458f5e to
9729a91
Compare
347ee9b to
fb30184
Compare
This Pull Request fixes/closes #4492.
It changes the following:
Example code