fix: documentation support status #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
force-pushed
the
repair-support-status
branch
from
e4e8d79 to
9bcad59
Compare
tinko92
approved these changes
Jul 22, 2025
Collaborator
tinko92
left a comment
tinko92
left a comment
There was a problem hiding this comment.
I am in favour of all the changes I see, was able to build with b2 and got output. I understand that the output has expected errors until a future PR, so I did not check it in detail. Based on that I approve.
Collaborator
Author
|
Thanks and I'll merge it already, it's small enough for 1 approval, and prepare next step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supported status matrix, as shown for example on https://www.boost.org/doc/libs/1_88_0/libs/geometry/doc/html/geometry/reference/algorithms/disjoint/disjoint_2.html
is generated automatically. There are (were) two tools for it.
It was originally created by myself in
implementation_status. That used to make a source of each algorithm, compile it for all combinations, and output the status. It took a long time (because it compiled each combination).It was enhanced by @awulkiew and placed into
support_status. That usesboost::is_base_ofto see if (for the algorithmdisjoint) the base classdispatch::disjointis implemented for the specified geometries. It compiles quickly and runs.But it is not used for a long time and it didn't fully compile anymore. At this moment, three algorithms didn't compile. After fixing them, it runs. But it does not always represents reality, or the reported state in the documentation. See below a remark about
disjoint.This PR is a minimal fix and will get a follow-up.
This PR contains:
implementation_status(by myself)support_status(by @awulkiew )I will make a follow-up PR with enhancements - but still containing the structure of
support_status.But I thought it is better to separate it.
The current support status also contains mismatches, such as:
which is not as on the documentation page, and not correct. A next PR will fix this.