Make boost::iostreams::detail::path constructible from std::filesystem::path#110
Make boost::iostreams::detail::path constructible from std::filesystem::path#110nikola-sh wants to merge 7 commits intoboostorg:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #110 +/- ##
========================================
Coverage 68.84% 68.85%
========================================
Files 80 80
Lines 3444 3445 +1
Branches 1027 1027
========================================
+ Hits 2371 2372 +1
Misses 454 454
Partials 619 619 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jeking3 Take a look at this PR please |
|
@mclow Take a look at this PR please |
|
I don't see any tests for this new functionality. The code looks reasonable, but w/o tests, do we know that it works? |
…:path and std::filesystem::path in one test
| [ test-iostreams | ||
| path_test.cpp | ||
| : [ check-target-builds ../../config/checks//cpp_lib_filesystem | ||
| : [ check-target-builds can_use_stdcxxfs : <source>stdc++fs : [ check-target-builds can_use_cxxfs : <source>c++fs ] ] |
There was a problem hiding this comment.
early gcc and clang versions requires to link specific filesystem library
|
@mclow I have added a test. |
|
@mclow Take a look at this PR again please |
|
any update on this one? |
3 participants
No description provided.