-
-
Notifications
You must be signed in to change notification settings - Fork 812
Fix windows file URLs #9097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows file URLs #9097
Conversation
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback. Windows file URLs confuse me. :)
7e427ec to
fcc5a5b
Compare
|
Linter is unhappy. Maybe do that to avoid this automatically: https://borgbackup.readthedocs.io/en/master/development.html#building-a-development-environment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9097 +/- ##
==========================================
- Coverage 81.07% 81.05% -0.03%
==========================================
Files 77 77
Lines 13540 13554 +14
Branches 2008 2011 +3
==========================================
+ Hits 10978 10986 +8
- Misses 1900 1904 +4
- Partials 662 664 +2 ☔ View full report in Codecov by Sentry. |
|
Thanks! Are changes in borgstore needed also? |
|
Hmm, looks like I overlooked another linter fail. I fixed it in #9108. |
I didn't have any, and haven't run into any other issues so far. |
Ensure that file URLs created from windows paths are valid, i.e. look like
file:///C:/foo/bar. Additionally I saw a few places wherepreexec_fnwas being used on windows, so I added guards there.Test results:
Related: #8474