-
Notifications
You must be signed in to change notification settings - Fork 345
feat(content-sidebar): add drag-to-resize handle behind feature flag #4559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmcbgaston
wants to merge
5
commits into
master
Choose a base branch
from
preview-sidebar-resizable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c89d504
feat(content-sidebar): add drag-to-resize handle behind feature flag
jmcbgaston 78bffd6
refactor(content-sidebar): address review feedback and add tests
jmcbgaston 94a887a
Merge branch 'master' into preview-sidebar-resizable
jmcbgaston 09f894f
Merge branch 'master' into preview-sidebar-resizable
jmcbgaston 6dbd5aa
fix(content-sidebar): satisfy Flow on pointer-capture method calls
jmcbgaston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /** | ||
| * @flow | ||
| * @file Sidebar Resize Handle — drag-to-resize grip on the left edge of the sidebar. | ||
| * @author Box | ||
| */ | ||
|
|
||
| import * as React from 'react'; | ||
| import './SidebarResizeHandle.scss'; | ||
|
|
||
| type Props = { | ||
| maxWidth: number, | ||
| minWidth: number, | ||
| onResize: (width: number) => void, | ||
| width: number, | ||
| }; | ||
|
|
||
| const clamp = (value: number, min: number, max: number): number => Math.min(Math.max(value, min), max); | ||
|
|
||
| const SidebarResizeHandle = ({ maxWidth, minWidth, onResize, width }: Props) => { | ||
| const startXRef = React.useRef<number>(0); | ||
| const startWidthRef = React.useRef<number>(width); | ||
| const [isDragging, setIsDragging] = React.useState(false); | ||
|
|
||
| const handlePointerMove = React.useCallback( | ||
| (event: PointerEvent) => { | ||
| // Sidebar lives on the RIGHT edge of the viewport, and the handle is on its LEFT edge. | ||
| // Dragging LEFT (smaller clientX) should GROW the sidebar. | ||
| const deltaX = startXRef.current - event.clientX; | ||
| const nextWidth = clamp(startWidthRef.current + deltaX, minWidth, maxWidth); | ||
| onResize(nextWidth); | ||
| }, | ||
| [maxWidth, minWidth, onResize], | ||
| ); | ||
|
|
||
| const handlePointerUp = React.useCallback( | ||
| (event: PointerEvent) => { | ||
| setIsDragging(false); | ||
| const { target } = event; | ||
| // Flow lib types pointer-capture methods as `(string)`; the real DOM API takes a number. | ||
| // Flow's Element doesn't declare `hasPointerCapture` either, so cast for that one call. | ||
| const pointerId = ((event.pointerId: any): string); | ||
| if (target instanceof Element && (target: any).hasPointerCapture(pointerId)) { | ||
| target.releasePointerCapture(pointerId); | ||
| } | ||
| window.removeEventListener('pointermove', handlePointerMove); | ||
| window.removeEventListener('pointerup', handlePointerUp); | ||
| }, | ||
| [handlePointerMove], | ||
| ); | ||
|
|
||
| const handlePointerDown = (event: SyntheticPointerEvent<HTMLDivElement>) => { | ||
| event.preventDefault(); | ||
| startXRef.current = event.clientX; | ||
| startWidthRef.current = width; | ||
| setIsDragging(true); | ||
| // Flow lib types setPointerCapture as `(string)`; the real DOM API takes a number. | ||
| // jsdom doesn't implement setPointerCapture, so guard the call. | ||
| if (typeof event.currentTarget.setPointerCapture === 'function') { | ||
| event.currentTarget.setPointerCapture(((event.pointerId: any): string)); | ||
| } | ||
| window.addEventListener('pointermove', handlePointerMove); | ||
| window.addEventListener('pointerup', handlePointerUp); | ||
| }; | ||
|
|
||
| React.useEffect(() => { | ||
| return () => { | ||
| window.removeEventListener('pointermove', handlePointerMove); | ||
| window.removeEventListener('pointerup', handlePointerUp); | ||
| }; | ||
| }, [handlePointerMove, handlePointerUp]); | ||
|
|
||
| return ( | ||
| <div | ||
| aria-hidden="true" | ||
| className={`bcs-resize-handle${isDragging ? ' bcs-resize-handle-is-dragging' : ''}`} | ||
| data-testid="sidebar-resize-handle" | ||
| onPointerDown={handlePointerDown} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default SidebarResizeHandle; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| @import '../common/variables'; | ||
|
|
||
| .bcs-resize-handle { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| z-index: 1; | ||
| width: 6px; | ||
| height: 100%; | ||
| cursor: col-resize; | ||
| background-color: transparent; | ||
| transition: background-color 0.15s ease; | ||
|
|
||
| &:hover, | ||
| &.bcs-resize-handle-is-dragging { | ||
| background-color: $bdl-box-blue; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.