Revert "Add DNS record for resume.brignano.io subdomain"#17
Conversation
Terraform Cloud Plan Output |
There was a problem hiding this comment.
Pull request overview
This pull request reverts PR #13, removing support for the resume.brignano.io subdomain from the infrastructure and documentation. The changes cleanly remove all DNS records and configuration related to the resume subdomain, simplifying the DNS setup to focus on the main domains and their www subdomains.
Changes:
- Removed the
resume.brignano.ioDNS CNAME record from Terraform infrastructure - Removed the associated Vercel CNAME record variable from locals configuration
- Updated documentation to reflect the removal of resume subdomain support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iac/main.tf | Removed the aws_route53_record.resume resource that created the DNS CNAME record for resume.brignano.io |
| iac/locals.tf | Removed the vercel_cname_record_resume local variable that was no longer needed |
| iac/README.md | Updated DNS management documentation to remove references to the resume subdomain |
| readme.md | Simplified domain management documentation to remove resume subdomain references and clarify www subdomain support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - www.brignano.io → Alias to brignano.io | ||
| - resume.brignano.io → Points to Vercel hosting (separate deployment) | ||
| - www.anthonybrignano.com → Points to Vercel hosting | ||
| - **WWW Redirect:** Both domains support www. subdomain |
There was a problem hiding this comment.
Grammar issue: "Both domains support www. subdomain" should be either "Both domains support www subdomain" (without the period after www) or "Both domains support a www subdomain" for better readability.
| - **WWW Redirect:** Both domains support www. subdomain | |
| - **WWW Redirect:** Both domains support a www subdomain |
Reverts #13
This pull request removes support for the
resume.brignano.iosubdomain and its associated DNS records from the Terraform infrastructure and documentation. The changes simplify the DNS setup by focusing only on the main domains and theirwwwsubdomains.Infrastructure and DNS record updates:
resume.brignano.ioCNAME DNS record resource frommain.tf.vercel_cname_record_resumelocal variable fromlocals.tf.Documentation updates:
iac/README.mdto remove references to theresumesubdomain and clarify the purpose of DNS management.readme.mdto remove mention of theresume.brignano.iosubdomain and clarify that onlywwwsubdomains are supported.