Throw type error if data is not string#296
Open
dlhandsome wants to merge 1 commit intobrix:developfrom
Open
Conversation
Author
Alanscut
approved these changes
Jun 9, 2020
Contributor
|
Looks Good 👍 |
|
Wouldn't this mean that you can't pass a WordArray object in anymore? Why would you want to remove that feature? |
Member
Adding type check is fine, but this should not remove the possibility to use WordArray beside String. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result would be the same if data is not a string when we want to get a hashcode.
For example:
So, we should throw type error under these circumstances.