Skip to content

handle rest args#8

Closed
broothie wants to merge 3 commits intomainfrom
abooth/handle-rest-args
Closed

handle rest args#8
broothie wants to merge 3 commits intomainfrom
abooth/handle-rest-args

Conversation

@broothie
Copy link
Copy Markdown
Owner

@broothie broothie commented Apr 6, 2025

No description provided.

@broothie broothie requested a review from Copilot April 6, 2025 22:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

for _, flag := range c.flags {
for _, short := range flag.shorts {
if flags[short] {
errs = append(errs, errors.Errorf("duplicate short flag %q", short))
Copy link

Copilot AI Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message for duplicate short flags does not include the command context and uses quote formatting that does not match the test expectations. Consider updating it to include the command name and adjust quote usage (e.g., 'invalid command "test": duplicate short flag 's'').

Suggested change
errs = append(errs, errors.Errorf("duplicate short flag %q", short))
errs = append(errs, errors.Errorf("invalid command %q: duplicate short flag '%c'", c.name, short))

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2025

Codecov Report

❌ Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.56%. Comparing base (6437d73) to head (9e00fac).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
context.go 27.27% 7 Missing and 1 partial ⚠️
parser.go 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   75.54%   75.56%   +0.01%     
==========================================
  Files          17       17              
  Lines         687      712      +25     
==========================================
+ Hits          519      538      +19     
- Misses        122      125       +3     
- Partials       46       49       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@broothie broothie closed this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants