fix: remove librosa as a hard dependency#70
Open
hmzonedocs-ship-it wants to merge 1 commit into
Open
Conversation
librosa pulls in numba → llvmlite, which requires compiling against a specific LLVM version (14) and fails on fresh macOS installs where only newer LLVM is available via brew. timeline_view.py already has an ffmpeg-based fallback for the waveform envelope and explicitly comments that librosa is not a hard dep. The core editing pipeline (transcription, EDL, render, grade) does not use librosa at all. Removing it from pyproject.toml lets `uv sync` complete without requiring a system LLVM installation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
librosafrompyproject.tomlhard dependencieslibrosapulls innumba → llvmlite, which requires compiling against LLVM 14 specifically and fails on fresh macOS installs where only newer LLVM is available via brewtimeline_view.pyalready has an ffmpeg-based fallback for the waveform envelope and explicitly comments that librosa is not a hard depTest plan
uv synccompletes without errors on a fresh macOS installtimeline_view.pywaveform generation works via ffmpeg fallback🤖 Generated with Claude Code
Summary by cubic
Removed
librosafrompyproject.tomlto avoid thenumba/llvmliteLLVM 14 build requirement and fixuv syncfailures on fresh macOS installs. Waveform generation uses the existingffmpegfallback, and the core editing pipeline is unaffected.Written for commit 7f683f3. Summary will update on new commits.