Skip to content

fix: correct auto-grade adjustment bounds in docstrings #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AGRO-CODEX wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix: correct auto-grade adjustment bounds in docstrings #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions helpers/grade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
per-clip correction. Samples N frames via ffmpeg, computes mean brightness,
RMS contrast, saturation. Emits a bounded filter string that corrects
under-exposure, flatness, and mild desaturation without applying any
creative color shift. All adjustments capped at ±8% on any axis.
creative color shift. Adjustments are bounded: contrast ±8%, gamma +10%/-6%,
saturation ±6%.

The goal is "make it look clean without looking graded". Never applies
creative LUTs, teal/orange splits, or filmic curves. For creative looks,
Expand Down Expand Up @@ -183,8 +184,9 @@ def auto_grade_for_clip(
) -> tuple[str, dict[str, float]]:
"""Analyze a clip range and emit a subtle per-clip correction filter.

Returns (filter_string, stats_dict). The filter is bounded to ±8% on any axis
and applies NO color shift. It only addresses:
Returns (filter_string, stats_dict). Adjustments are bounded per axis
(contrast ±8%, gamma +10%/-6%, saturation ±6%) and apply NO color shift.
It only addresses:
- Underexposure (lift gamma slightly if too dark)
- Flatness (tiny contrast boost if range is narrow)
- Desaturation (tiny sat boost if extremely flat)
Expand Down