Skip to content

Keep-Alive#764

Open
gronke wants to merge 13 commits intomasterfrom
chore/keepalive
Open

Keep-Alive#764
gronke wants to merge 13 commits intomasterfrom
chore/keepalive

Conversation

@gronke
Copy link
Copy Markdown
Member

@gronke gronke commented Nov 13, 2020

  • refactor requirement parsing in setup.py

@igalic
Copy link
Copy Markdown
Collaborator

igalic commented Nov 13, 2020

given that libioc is a library, we should python packaging best practices, and not have a requirements.txt, much less use unstable APIs to parse it

we could use the same approach i suggested in gronke/py-freebsd_sysctl#9 and add our requirements in setup.cfg, and get rid of a lot of useless code

igalic
igalic reviewed Nov 14, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙋🏻‍♀️

Comment thread setup.cfg Outdated
@igalic igalic mentioned this pull request Nov 14, 2020
Open
igalic
igalic requested changes Nov 14, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙋🏻‍♀️

Comment thread setup.cfg Outdated
install_requires =
gitpython
freebsd_sysctl==0.0.7
jail==0.0.11
Copy link
Copy Markdown
Collaborator

@igalic igalic Nov 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keeps us only one step away from the current setup
we should use ranges in libioc, and only in ioc use exact versions of the published (on ports) packages

Copy link
Copy Markdown
Member Author

@gronke gronke Nov 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that major version pinning is sufficient. Meanwhile the interfaces of both tools are stable enough to not break.

Copy link
Copy Markdown
Collaborator

@igalic igalic Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time for a 1.0 release then

gronke added a commit that referenced this pull request Jun 23, 2021
@gronke
add iocage/iocell to package keywords
af8c810 
addresses #764 (comment)
@gronke gronke force-pushed the chore/keepalive branch from 2b3a58a to af8c810 Compare June 23, 2021 11:13
@gronke gronke force-pushed the chore/keepalive branch from af8c810 to 6881fac Compare June 23, 2021 11:18
@igalic
Copy link
Copy Markdown
Collaborator

igalic commented Jul 21, 2021

why are the cirrus tests failing like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igalic igalic igalic requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gronke @igalic @thatch