Skip to content

fix(loop-function): handle async or generator function#224

Open
vitorveiga wants to merge 2 commits intobublejs:masterfrom
jscrambler:fix/auto-generated-loop-function
Open

fix(loop-function): handle async or generator function#224
vitorveiga wants to merge 2 commits intobublejs:masterfrom
jscrambler:fix/auto-generated-loop-function

Conversation

@vitorveiga
Copy link
Copy Markdown
Contributor

Hello,

Transpiling the following snippet with options generator and asyncAwait disabled:

function* foo() {
  do {
    yield 1;
    const b = "string";

    function x() {
      console.log(b);
    }

    x();
  } while (1);
}

the result is:

function* foo() {
    var loop = function () {
        yield 1;
        var b = "string";

        function x() {
            console.log(b);
        }

        x();
    };
    do {
        loop();
    } while (1);
};

Evaluating the transpiled code, a Syntax Error occur due to the missing '*' in loop function.

Note: Same behaviour in async functions.

@vitorveiga vitorveiga closed this Sep 30, 2019
@vitorveiga
Copy link
Copy Markdown
Contributor Author

Semantically different. Working on a possible solutions.

@vitorveiga vitorveiga reopened this Sep 30, 2019
@vitorveiga
Copy link
Copy Markdown
Contributor Author

In order to be semantically equal, it was add await loop() for async function and yield* for generator functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant