chore(llm): remove redundant schema feature gate from zeph-llm#2108
Merged
chore(llm): remove redundant schema feature gate from zeph-llm#2108
Conversation
schemars is a non-optional dependency in 7 other workspace crates (zeph-core, zeph-tools, zeph-skills, zeph-mcp, zeph-acp, zeph-orchestration, zeph-memory), so the schema feature in zeph-llm was always effectively enabled. Make schemars non-optional and remove 37 #[cfg(feature = "schema")] annotations across 10 files. Closes #2100
bug-ops
added
llm
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemarsa non-optional dependency incrates/zeph-llm/Cargo.tomlschemafeature declaration anddefault = ["schema"]#[cfg(feature = "schema")]annotations across 10 source filesschemarswas always compiled viazeph-core,zeph-tools,zeph-skills,zeph-mcp,zeph-acp,zeph-orchestration, andzeph-memoryTest plan
cargo +nightly fmt --check— PASScargo clippy --workspace --features full -- -D warnings— PASScargo nextest run --workspace --features full --lib --bins— PASS (6365 tests)Closes #2100