Skip to content

Allow unlimited patches in container image script#197

Merged
moroten merged 1 commit into
mainfrom
unlimited-patches
Jun 17, 2026
Merged

Allow unlimited patches in container image script#197
moroten merged 1 commit into
mainfrom
unlimited-patches

Conversation

@oscar-meroton

Copy link
Copy Markdown
Collaborator

Allow the image update script to include an arbitrary number of patches in the MODULE.bazel Git overrides, previously limited to three patches. Also gives the timestamp extraction function a more descriptive name.

is_target_found = 0
next
}
is_in_block {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this is new to me. Is this an implicit conditional on the variable?

similar to how END could just be a boolean,
and if would conveniently return a boolean (speculation)?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how END and control statements are evaluated in awk, but this is using the pattern/action syntax with an expression as the pattern.

https://www.gnu.org/software/gawk/manual/html_node/Action-Overview.html
https://www.gnu.org/software/gawk/manual/html_node/Pattern-Overview.html

@oscar-meroton oscar-meroton marked this pull request as draft June 16, 2026 10:19
@oscar-meroton oscar-meroton force-pushed the unlimited-patches branch 2 times, most recently from 4ddddee to 6fc433e Compare June 16, 2026 10:47
@oscar-meroton oscar-meroton marked this pull request as ready for review June 16, 2026 10:47
Comment thread tools/update-container-image-versions.sh Outdated
Allow the image update script to include an arbitrary
number of patches in the MODULE.bazel Git overrides,
previously limited to three patches. Also gives the
timestamp extraction function a more descriptive name.
@moroten moroten merged commit 9f58920 into main Jun 17, 2026
3 checks passed
@moroten moroten deleted the unlimited-patches branch June 17, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants