Document the manual error check for repo version#199
Merged
moroten merged 2 commits intoJun 18, 2026
Conversation
stagnation
force-pushed
the
feature/document-the-manual-error-check-for-repo-version
branch
from
b0ae4cd to
e3fa11c
Compare
Collaborator
|
lgtm, thanks for looking into this! |
oscar-meroton
approved these changes
Jun 18, 2026
moroten
deleted the
feature/document-the-manual-error-check-for-repo-version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly improves the code around the manual error check for curl. Where curl's own message is verbose progress information combined with a suboptimal message on errors: "curl: (22) The requested URL returned error: 422".
During development we had a "huh, that is weird" and realized that subshells do not inherit the error exit settings. We do use subshells rather than ouptut variables for function calls.