Fix size calculations in the WinFSP symlink reparse buffer#233
Open
tomgr wants to merge 1 commit into
Open
Conversation
FillSymlinkReparseBuffer derived the reparse data length from sizeof(SymbolicLinkReparseBuffer), which rounds the struct up for its uint32 Flags field and so carried 2 bytes of superfluous padding. The PathBuffer slice was also built with a length in bytes where uint16 elements were required, making it twice as long as the backing storage. Neither appears to cause a problem in practice but probably good to clean up.
EdSchouten
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FillSymlinkReparseBuffer derived the reparse data length from sizeof(SymbolicLinkReparseBuffer), which rounds the struct up for its uint32 Flags field and so carried 2 bytes of superfluous padding.
The PathBuffer slice was also built with a length in bytes where uint16 elements were required, making it twice as long as the backing storage.
Neither appears to cause a problem in practice but probably good to clean up.