Don't reject WinFSP file attributes the VFS can't represent#234
Merged
Conversation
toVirtualAttributes returned STATUS_INVALID_PARAMETER for any attribute that was unsupported. However, given that Windows sets FILE_ATTRIBUTE_ARCHIVE on an ordinary CREATE_ALWAYS, that meant propagating the error would fail normal file creation (the winfsp-tests create_test covers this). Instead we now ignore attributes the VFS can't represent, and instead only return errors when we know there is something incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toVirtualAttributes returned STATUS_INVALID_PARAMETER for any attribute that was unsupported. However, given that Windows sets FILE_ATTRIBUTE_ARCHIVE on an ordinary CREATE_ALWAYS, that meant propagating the error would fail normal file creation (the winfsp-tests create_test covers this).
Instead we now ignore attributes the VFS can't represent, and instead only return errors when we know there is something incorrect.