refactor(tarko): standardize tool renderer system #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace complex condition-based renderer selection with type-safe transformer system - Create standardized data formats for each renderer type (ImageData, FileData, etc.) - Implement transformer functions for consistent data conversion - Add StandardRenderer adapter for backward compatibility - Maintain existing renderer components while enabling gradual migration - Improve type safety and reduce runtime errors - Simplify renderer configuration and eliminate dynamic content detection
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the Tool Renderer system to address type safety issues, data structure inconsistencies, and configuration complexity. This PR replaces the complex condition-based renderer selection with a standardized transformer system.
Key Improvements:
any/stringparameters with strongly-typedStandardToolResultandRendererDataunion typesImageData,FileData,DiffData, etc.)StandardRendereradapter to work with existing renderer componentsTechnical Changes:
@/common/utils/tool-renderers/types.tswith standardized type definitionsStandardRenderercomponent as adapter between new and legacy systemsToolHandlerto generate standardized results alongside legacy formatMigration Path:
Checklist