Remove optional gen parameter from bytes_size and string_size generators#403
Merged
jmid merged 10 commits intoc-cube:mainfrom Jan 31, 2026
Merged
Remove optional gen parameter from bytes_size and string_size generators#403jmid merged 10 commits intoc-cube:mainfrom
gen parameter from bytes_size and string_size generators#403jmid merged 10 commits intoc-cube:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of The Great Renaming in 0.90 we kicked a couple of cans further down the road, regarding optional
genparameters to thebytes_sizeandstring_sizegenerators.From #371 on
bytes:and from #372 on
string:To move forward with the 1.0.0 release, this PR thus keeps the promise and removes the redundant
?genparameter.This is an API breaking change, which is precisely why it was postponed to the 1.0.0 release, for semantic-versioning-harmony 🌞
Any usage, e.g.,
bytes_size ~gen sizecan be easily rewritten tobytes_size_of size gen.