remove unnecessary libs, add general improvements#7
Conversation
cGuille
left a comment
cGuille
left a comment
There was a problem hiding this comment.
Hello,
Thank you for your contribution.
I am not sure how to feel about this. This looks like a breaking change at two levels:
- Break web browser compatibility.
- Break backwards compatibility, since it requires JS classes, that might not be available in every engine that was previously supported.
I am not into JS / node this days, so I am not sure about investing time in a library that was not updated for years.
I don't mind to transfer ownership or mark the repo as deprecated in favor of something else, though.
| @@ -1,79 +1,66 @@ | |||
| (function () { | |||
| 'use strict'; | |||
| const EventEmitter = require('events'); | |||
There was a problem hiding this comment.
Doesn't this break web browser support?
There was a problem hiding this comment.
Perhaps add a EventEmitter polyfill for older browsers?
There was a problem hiding this comment.
And add Babel for getting around issues with JS classes?
|
Maybe it's just more appropriate to just define the class in your project, as this lib is very small and simple. |
|
@fedealconada: I have been looking at a lot of polling modules on npm / github, and I really like how simple and effective the interface of this module is. It's a shame it's not maintained! I'd definitely give a thumbs up, to creating a fork of this update as a new repository 😃 |
3 participants
No description provided.