ci: run the cockpit shell control-plane e2e, which nothing invoked - #943
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
enabled auto-merge (squash)
September 2, 2026 00:51
blove
force-pushed
the
blove/ci-wire-cockpit-control-plane-e2e
branch
from
September 2, 2026 01:01
f90e554 to
495df35
Compare
Contributor
#921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over the operational sidebar: the real Angular handshake without blank or unresponsive states, operational controls reachable at four viewports, forced colors preserving control boundaries and keyboard focus, and reduced motion disabling loader and drawer animation. Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the cockpit-e2e matrix only dispatches caps derived from walking cockpit/** — apps/cockpit is never a candidate. No other job named the target either: grepping every workflow for `nx e2e` returns examples-chat-angular, examples-ag-ui-angular, the cap matrix, and website. So this has been dead coverage for its whole life. Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes in the existing `cockpit` job rather than a new one because it is cheap, it reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and required-pr-checks already aggregates the job — so it becomes merge-blocking with no gate change. The playwright config already sets retries: 2 on CI. Found while auditing the tags I removed from apps/cockpit in #939. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
force-pushed
the
blove/ci-wire-cockpit-control-plane-e2e
branch
from
September 2, 2026 01:32
495df35 to
af0b68f
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while auditing the tags I removed from
apps/cockpitin #939.#921 added
apps/cockpit/e2e/control-plane.spec.ts— 7 Playwright tests over the operational sidebar:Nothing has ever run it. The suite sits behind
nx e2e cockpit, and the cockpit-e2e matrix only dispatches caps derived from walkingcockpit/**—apps/cockpitis never a candidate. No other job names the target either; grepping every workflow fornx e2ereturns onlyexamples-chat-angular,examples-ag-ui-angular, the cap matrix, andwebsite.Verified before wiring
Ran it locally first, because wiring up a suite that doesn't pass is worse than leaving it dormant:
Placement
It goes in the existing
cockpitjob rather than a new one:npm cicockpitscope already gates the shell correctlyrequired-pr-checksalready aggregates that job, so this becomes merge-blocking with no gate changeThe playwright config already sets
retries: 2under CI. Playwright browsers are cached with the same key the other e2e jobs use.Tests
ci-workflow.spec.mjsgains a guard asserting thecockpitjob runsnx e2e cockpitand installs a browser — confirmed failing first:All six
node --testsuites pass after (134/134).🤖 Generated with Claude Code