libstore: Fix dev environments with CA derivations - #9
Merged
domenkozar merged 1 commit intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildEnvironment::getDevEnvironmentfillInOutputPaths()ca-derivationsis enabledRoot cause
The fork moved development-environment extraction from
src/nix/develop.ccinto libstore after the upstream fix had landed, but the extracted implementation retained the older CA feature branch. Whenca-derivationswas enabled for an otherwise input-addressed derivation, that branch put Nix's deferred hash placeholder inout. Derivation validation then rejected the generated environment because the variable did not match its computed store path.Impact
Consumers of
BuildEnvironment::getDevEnvironment, including devenv's C API integration, can now obtain development environments whenca-derivationsis enabled.Fixes cachix/devenv#2364.
Related devenv change: cachix/devenv#3044.
Validation
nix-functional-tests:ca / develop-input-addressed: 1 passed, 0 failedbash -non the new testThe repository-wide pre-commit derivation still reports pre-existing formatting drift in unrelated files; the changed files pass their targeted formatters.