Add missing x86_64-apple-darwin Rust target to macOS CI job#298
Merged
kraenhansen merged 3 commits intokh/macos-test-appfrom Oct 28, 2025
Merged
Add missing x86_64-apple-darwin Rust target to macOS CI job#298kraenhansen merged 3 commits intokh/macos-test-appfrom
kraenhansen merged 3 commits intokh/macos-test-appfrom
Conversation
Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add MacOS test app and fix hermes vendoring from react-native-macos
Add missing Rust targets to macOS CI job
Oct 28, 2025
Collaborator
|
@copilot just needed the missing target 😅 and you added the arm64 target as well. This is already installed as it's the host. Please stick to the instructions and add only the x86_64 target. |
Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com>
Author
Fixed to only add the missing x86_64-apple-darwin target since aarch64-apple-darwin is already available as the host. Commit: ea81260 |
Copilot
AI
changed the title
Add missing Rust targets to macOS CI job
Add missing x86_64-apple-darwin Rust target to macOS CI job
Oct 28, 2025
kraenhansen
approved these changes
Oct 28, 2025
kraenhansen
added a commit
that referenced
this pull request
Nov 2, 2025
No need to Setup Android SDK Debugging with Copilot Pass --mode when building from CLI Install CMake 3.22 Fix bootstrap issue Trying a higher CMake version Remove debug info from workflow Build universal Darwin libraries Add missing x86_64-apple-darwin Rust target to macOS CI job (#298) * Initial plan * Add missing x86_64-apple-darwin Rust target to macOS job Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> * Add only missing x86_64-apple-darwin target (aarch64 is host) Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> Run MacOS test app Use package script to run all tests
kraenhansen
added a commit
that referenced
this pull request
Nov 2, 2025
* Remove platform restriction from host package's podspec * Add fallback for watchFolders in the metro config * Update Podspec to detect React Native package name * Add script to init a MacOS test app Enable Hermes and Fabric Patch react_native_post_install to pass react native path Don't pod install when initializing Patch macos app with scripts and source files Re-arm the init script Move linked deps into install command to make --install-links effective Using regular linking for monorepo deps Include original dependencies Enable new arch in Podfile Fix comment from review * Add job in the check workflow to initialize and build the MacOS test app No need to Setup Android SDK Debugging with Copilot Pass --mode when building from CLI Install CMake 3.22 Fix bootstrap issue Trying a higher CMake version Remove debug info from workflow Build universal Darwin libraries Add missing x86_64-apple-darwin Rust target to macOS CI job (#298) * Initial plan * Add missing x86_64-apple-darwin Rust target to macOS job Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> * Add only missing x86_64-apple-darwin target (aarch64 is host) Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com> Run MacOS test app Use package script to run all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS test job was failing because it configured
FERRIC_TARGETS: aarch64-apple-darwin,x86_64-apple-darwinbut didn't install the corresponding Rust target.Changes
rustup target add x86_64-apple-darwinto the test-macos job before bootstrap stepThis adds only the missing x86_64 target since aarch64-apple-darwin is already available as the host architecture on macOS runners.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.