Pass headerpad_max_install_names to linker#346
Merged
kraenhansen merged 2 commits intomainfrom Feb 1, 2026
Merged
Conversation
headerpad_max_install_names to linker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see failures building for MacOS here: https://github.com/callstackincubator/react-native-node-api/actions/runs/21562769725/job/62133783654
Merging this PR will:
-headerpad_max_install_namesargument to the linker to increase the padding of the header to allow updating the install name of library files when linking them into the app.weak-node-apias a dependency to the "MacOS test app" (missed this in Separateweak-node-apipackage #308).