feat: added support for multi-project setups#592
Open
Vo1dSh4d0w wants to merge 2 commits into
Open
Conversation
Contributor
|
This PR has not been updated in a while. If it is still relevant, please comment on it to keep it open. The PR will be closed soon if it remains inactive. |
Contributor
|
Hi Filip, thanks for pointing this scenario out and for providing a fix. Also, could you please let me know why your projects need differing layouts? This is a use case we have not yet encountered. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
these changes allow multi-project setups to be compiled using cds-typer. We need this change, because our project structure does not exactly match the structure in our target directory (gen), therefore we have a tsconfig each for our 2 separated projects.
With these changes, in order to build 2 projects, the build defintion has to be modified manually, for example:
This change works by joining every project related path (like tsconfig.cdsbuild.json) with the configured "src", I've also added a check to the configured "dest", which ensures that a custom "dest" won't be overwritten in the "init()" function.
I've tested this patch both with our real project and with a smaller project without any explicit build configuration.