fix: fixes issues in ql SELECT.from(...) when using typer classes#268
Merged
Conversation
d9f3ec0 to
2fbb13b
Compare
Contributor
Author
|
Due to #201, Issue 1) no longer exists, and fix for issue 2) has been adjusted |
daogrady
reviewed
Oct 21, 2024
| let selectMany: Foos | ||
|
|
||
| // SINGULAR TESTS | ||
| selectOne = await SELECT.from(Foos.drafts, 42) // .drafts of plural still singular |
Contributor
There was a problem hiding this comment.
this is actually an open question as of today. 🫠 But let's roll with it for now.
daogrady
approved these changes
Oct 24, 2024
daogrady
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for fixing this! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues
Sample schema
Generated classes from cds-typer
Issues
1) No compiler issues, but both queries actually return typeanyinstead ofBook